Clean up the druid sync api.#1101
Merged
bkyryliuk merged 2 commits intoapache:masterfrom Sep 14, 2016
bkyryliuk:druid_sync_json
Merged
Clean up the druid sync api.#1101bkyryliuk merged 2 commits intoapache:masterfrom bkyryliuk:druid_sync_json
bkyryliuk merged 2 commits intoapache:masterfrom
bkyryliuk:druid_sync_json
Conversation
Member
|
LGTM |
dennisobrien
pushed a commit
to dennisobrien/caravel
that referenced
this pull request
Sep 19, 2016
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the druid sync api to pass the data as the json blob rather than 3 separate attributes.
Reviewers: